Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of boxes #225

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add list of boxes #225

merged 1 commit into from
Sep 11, 2024

Conversation

leo-barnes
Copy link
Collaborator

@leo-barnes leo-barnes commented Sep 10, 2024

Closes #167.

This is a rebase and fixup of PR #170.
The section on box requirements for sequences has been removed until someone has taken the time to fully go through it.


Preview | Diff

@leo-barnes leo-barnes marked this pull request as ready for review September 10, 2024 09:19
@leo-barnes
Copy link
Collaborator Author

@cconcolato
I have rebased your changes for #170 and fixed up indentation and some bikeshed warnings.

I also removed the section for sequences for now.

Copy link
Collaborator

@y-guyon y-guyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the versions of the boxes against ISO/IEC 14496-12 8th 2nd rev 2nd DIS and ISO/IEC 23008-12 3rd.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Closes #167.
This is a rebase and fixup of PR #170.
The section on box requirements for sequences has been removed until someone has taken the time to fully go through it.
@leo-barnes leo-barnes merged commit c1f956f into master Sep 11, 2024
@leo-barnes leo-barnes deleted the u/lbarnes/add_avif_box_list branch September 11, 2024 17:45
@wantehchang wantehchang removed their request for review September 11, 2024 17:55
@wantehchang
Copy link
Collaborator

@vigneshvg Vignesh: Please review. Thanks!

@vigneshvg
Copy link

yes, the list of boxes look good to me. the only thing that i found to be missing was the ccst box that libavif writes out for animated images: https://github.com/AOMediaCodec/libavif/blob/85979a79983573c908958cd27197290cd19ea7b6/src/write.c#L3504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVIF should have a table of boxes and box versions
4 participants