Skip to content

Commit

Permalink
Revert "[CI] setup Chrome and utilize binary path (opensearch-project…
Browse files Browse the repository at this point in the history
…#3997)"

This reverts commit 0188d05

Signed-off-by: Miki <[email protected]>
  • Loading branch information
AMoo-Miki committed May 20, 2023
1 parent 152a2e4 commit 795c9b2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 30 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/build_and_test_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -344,17 +344,6 @@ jobs:
npm i -g [email protected]
yarn config set network-timeout 1000000 -g
- name: Configure Yarn Cache
run: echo "YARN_CACHE_LOCATION=$(yarn cache dir)" >> $GITHUB_ENV

- name: Initialize Yarn Cache
uses: actions/cache@v3
with:
path: ${{ env.YARN_CACHE_LOCATION }}
key: yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
yarn-
- name: Get package version
run: |
echo "VERSION=$(yarn --silent pkg-version)" >> $GITHUB_ENV
Expand Down
21 changes: 2 additions & 19 deletions scripts/upgrade_chromedriver.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,34 +25,17 @@ const versionCheckCommands = [];
switch (process.platform) {
case 'win32':
versionCheckCommands.push(
...[
...(process.env.TEST_BROWSER_BINARY_PATH
? [
`powershell "(Get-Item \\"${process.env.TEST_BROWSER_BINARY_PATH}\\").VersionInfo.FileVersion"`,
]
: []),
'powershell "(Get-Item \\"$Env:Programfiles/Google/Chrome/Application/chrome.exe\\").VersionInfo.FileVersion"',
]
'powershell "(Get-Item \\"$Env:Programfiles/Google/Chrome/Application/chrome.exe\\").VersionInfo.FileVersion"'
);
break;

case 'darwin':
versionCheckCommands.push(
...[
...(process.env.TEST_BROWSER_BINARY_PATH
? [`${process.env.TEST_BROWSER_BINARY_PATH} --version`]
: []),
'/Applications/Google\\ Chrome.app/Contents/MacOS/Google\\ Chrome --version',
]
'/Applications/Google\\ Chrome.app/Contents/MacOS/Google\\ Chrome --version'
);
break;

default:
versionCheckCommands.push(
...(process.env.TEST_BROWSER_BINARY_PATH
? [`${process.env.TEST_BROWSER_BINARY_PATH} --version`]
: [])
);
versionCheckCommands.push(
...[
'/usr/bin',
Expand Down

0 comments on commit 795c9b2

Please sign in to comment.