Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix periodic boundary bug in #3199 #3243

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Fix periodic boundary bug in #3199 #3243

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba23365
Make sure we always have rhi < phi, even if only one iteration is needed
atmyers Apr 7, 2023
2906d53
fix in a different way
atmyers Apr 7, 2023
d9cfb9d
also use rlo and rhi instead of plo and phi for the outermost if test
atmyers Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Src/Particle/AMReX_ParticleUtil.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,8 @@ bool enforcePeriodic (P& p,
p.pos(idim) += static_cast<ParticleReal>(phi[idim] - plo[idim]);
}
// clamp to avoid precision issues;
if (p.pos(idim) > rhi[idim]) {
p.pos(idim) = rhi[idim];
if (p.pos(idim) >= rhi[idim]) {
p.pos(idim) = std::nextafter(p.pos(idim), rlo[idim]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks like the right thing to do.

}
shifted = true;
}
Expand Down