Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] make disable_shock_burning = 1 by default #2986

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

[WIP] make disable_shock_burning = 1 by default #2986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a11a30
make disable_shock_burning = 1 by default
zingale Nov 6, 2024
e78f1e1
fix test
zingale Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Exec/Make.Castro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ ifeq ($(USE_HYBRID_MOMENTUM), TRUE)
endif
endif

ifeq ($(USE_REACT), TRUE)
USE_SHOCK_VAR = TRUE
endif

ifeq ($(USE_SHOCK_VAR), TRUE)
DEFINES += -DSHOCK_VAR
endif
Expand Down
2 changes: 2 additions & 0 deletions Source/driver/Castro.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,9 +416,11 @@ Castro::read_params ()
#endif

#ifndef SHOCK_VAR
#ifdef REACTIONS
if (disable_shock_burning != 0) {
amrex::Error("ERROR: disable_shock_burning requires compiling with USE_SHOCK_VAR=TRUE");
}
#endif
#endif

if (riemann_solver == 1) {
Expand Down
2 changes: 1 addition & 1 deletion Source/driver/_cpp_parameters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ react_rho_max Real 1.e200

# disable burning inside hydrodynamic shock regions
# note: requires compiling with `USE_SHOCK_VAR=TRUE`
disable_shock_burning bool 0
disable_shock_burning bool 1

# shock detection threshold for grad{P} / P
shock_detection_threshold Real 0.6666666666666666666666_rt
Expand Down
Loading