POCONC-219: Fix patient summary snapshots #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
changed the title
denniskigen
force-pushed
the
POCONC-219
branch
from
8d844ea
to
b3760a9
Compare
This PR tweaks the stored procedure to get it to work within the constraints of other modifications to the breast and cervical cancer screening procedures. More specifically, these changes include: - Renaming indicators: - `breast_exam_findings` to `breast_exam_findings_this_visit`. Also changes the way the value of this indicator is determined using a subtle hack (necessitated by a bug in the form's design where past_breast_exam_findings and breast_exam_findings_this_visit reuse the same concept ID). - `via_test_result` to `via_or_via_vili_test_result`. Also changes to the way the value of this indicator is determined. This changes are necessitated by earlier modifications to the cervical cancer screening form. - Add a new indicator - `observations_from_positive_via_or_vili_test` which aggregates positive screening finding results. - Linting (sorry, not sorry).
denniskigen
force-pushed
the
POCONC-219
branch
from
b3760a9
to
00b2474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the stored procedure to work within the context of erstwhile modifications to the breast and cervical cancer screening procedures. More specifically, these changes include:
breast_exam_findingsindicator tobreast_exam_findings_this_visit.via_test_resultindicator tovia_or_via_vili_test_result.breast_exam_findings_this_visitindicator gets computed. Involves introducing a subtle hack that counters a bug in the design of the form where this indicator and another (past_breast_exam_findings) reuse the same concept ID.via_or_via_vili_test_resultindicator gets computed.observations_from_positive_via_or_via_vili_testwhich aggregates positive screening finding results.