Optional warning in fill_in_parameters
#2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`amici.petab.conditions.fill_in_parameters` emits a warnings if parameters are supplied that don't occur in the parameter mapping. This is to point out potential issues with the parameter mapping. However, sometimes it's more convenient to silently ignore those extra parameters. Therefore, make this warning optional.
dweindl
force-pushed
the
petab_warn_unused
branch
from
89130a3
to
c06df1d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2578 +/- ##
========================================
Coverage 77.76% 77.76%
========================================
Files 325 325
Lines 21861 21862 +1
Branches 1473 1473
========================================
+ Hits 17000 17001 +1
Misses 4834 4834
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Merged
FFroehlich
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amici.petab.conditions.fill_in_parametersemits a warnings if parameters are supplied that don't occur in the parameter mapping. This is to point out potential issues with the parameter mapping. However, sometimes it's more convenient to silently ignore those extra parameters. Therefore, make this warning optional.