Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Don't attempt to create alias target if target of the same name already exists #2547

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 17, 2024

Fixes #2546.

@dweindl dweindl requested a review from a team as a code owner October 17, 2024 10:32
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.79%. Comparing base (d4bb0ce) to head (aaf69bc).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2547   +/-   ##
========================================
  Coverage    77.79%   77.79%           
========================================
  Files          325      325           
  Lines        21058    21058           
  Branches      1473     1473           
========================================
  Hits         16383    16383           
  Misses        4648     4648           
  Partials        27       27           
Flag Coverage Δ
cpp 73.51% <ø> (ø)
cpp_python 34.05% <ø> (ø)
petab 37.05% <ø> (ø)
python 72.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl merged commit 9f821d9 into AMICI-dev:develop Oct 17, 2024
19 of 20 checks passed
@dweindl dweindl deleted the fix_2546_model_target branch October 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants