Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Set SUNDIALS_ROOT #2468

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 26, 2024

Set SUNDIALS_ROOT to ensure we are finding the sundials CMake config from the vendored library and not any other installation.

Fixes #2467.

Set SUNDIALS_ROOT to ensure we are finding the sundials CMake config from the vendored library and not any other installation.

Fixes AMICI-dev#2467.
@dweindl dweindl requested a review from a team as a code owner June 26, 2024 07:37
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.63%. Comparing base (474b473) to head (c7fb4cb).
Report is 25 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2468      +/-   ##
===========================================
- Coverage    77.65%   77.63%   -0.02%     
===========================================
  Files          324      324              
  Lines        20927    20927              
  Branches      1464     1464              
===========================================
- Hits         16250    16247       -3     
- Misses        4674     4677       +3     
  Partials         3        3              
Flag Coverage Δ
cpp 73.39% <ø> (-0.02%) ⬇️
cpp_python 34.09% <ø> (ø)
petab 36.66% <ø> (ø)
python 72.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@dweindl dweindl linked an issue Jun 26, 2024 that may be closed by this pull request
@dweindl dweindl self-assigned this Jun 26, 2024
@dweindl dweindl merged commit f8ce650 into AMICI-dev:develop Jun 27, 2024
19 of 20 checks passed
@dweindl dweindl deleted the fix_cmake_sundials branch June 27, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake Error during AMICI installation on WSL
2 participants