Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify cmake build types and require cmake-build-extension==0.6.0 #2445

Merged
merged 11 commits into from
May 16, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 14, 2024

Copy link

socket-security bot commented May 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] environment, filesystem, shell Transitive: eval, network, unsafe +152 1.27 GB dgferigo

🚮 Removed packages: pypi/[email protected], pypi/[email protected]

View full report↗︎

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.64%. Comparing base (59256b4) to head (ef19171).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2445   +/-   ##
========================================
  Coverage    77.64%   77.64%           
========================================
  Files          324      324           
  Lines        20930    20930           
  Branches      1464     1464           
========================================
  Hits         16251    16251           
  Misses        4676     4676           
  Partials         3        3           
Flag Coverage Δ
cpp 73.41% <ø> (ø)
cpp_python 34.10% <ø> (ø)
petab 36.66% <ø> (ø)
python 72.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl changed the title Require cmake-build-extension==0.6.0 Specify cmake build types and require cmake-build-extension==0.6.0 May 15, 2024
@dweindl dweindl self-assigned this May 15, 2024
@dweindl dweindl marked this pull request as ready for review May 16, 2024 09:10
@dweindl dweindl requested a review from a team as a code owner May 16, 2024 09:10
@dweindl dweindl merged commit 7f7be0f into AMICI-dev:develop May 16, 2024
20 checks passed
@dweindl dweindl deleted the cmakebuildext branch May 16, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants