Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dxdotdw for RateRules #1584

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Fix dxdotdw for RateRules #1584

merged 4 commits into from
Nov 11, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 9, 2021

Fixes a bug where dxdotdw would be wrongly set to zero despite w-dependent SBML RateRules.

Fixes #1583

Fixes a bug where dxdotdw would be wrongly set to zero despite w-dependent
SBML RateRules.

Partial fix for #1583
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1584 (5c5f633) into develop (0374f87) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1584      +/-   ##
===========================================
+ Coverage    78.85%   78.88%   +0.02%     
===========================================
  Files           67       67              
  Lines        10649    10644       -5     
===========================================
- Hits          8397     8396       -1     
+ Misses        2252     2248       -4     
Flag Coverage Δ
cpp 75.35% <ø> (+0.05%) ⬆️
petab 66.93% <100.00%> (-0.05%) ⬇️
python 67.73% <100.00%> (-0.05%) ⬇️
sbmlsuite 87.80% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/ode_export.py 92.86% <ø> (ø)
python/amici/sbml_import.py 95.76% <100.00%> (-0.04%) ⬇️
src/solver_cvodes.cpp 71.29% <0.00%> (+0.18%) ⬆️
src/sundials_matrix_wrapper.cpp 82.33% <0.00%> (+0.22%) ⬆️
src/exception.cpp 80.64% <0.00%> (+6.45%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl merged commit 9e96a6e into develop Nov 11, 2021
@dweindl dweindl deleted the fix_1583 branch November 11, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants