Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Additional nightly tests #1578

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 25, 2021

Regularly check benchmark collection models, performance tests and documentation.

Regularly check benchmark collection models, performance tests and documentation.
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1578 (186f38f) into develop (b4e33bb) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1578      +/-   ##
===========================================
+ Coverage    78.81%   78.83%   +0.01%     
===========================================
  Files           67       67              
  Lines        10636    10636              
===========================================
+ Hits          8383     8385       +2     
+ Misses        2253     2251       -2     
Flag Coverage Δ
cpp 75.31% <ø> (+0.02%) ⬆️
petab 67.14% <ø> (ø)
python 67.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sundials_matrix_wrapper.cpp 82.33% <0.00%> (+0.45%) ⬆️

@FFroehlich
Copy link
Member

Regularly check benchmark collection models, performance tests and documentation.

I see the motivation for doing this for benchmark collection models, but why do we need this for performance/documentation?

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl
Copy link
Member Author

dweindl commented Oct 26, 2021

I see the motivation for doing this for benchmark collection models, but why do we need this for performance/documentation?

They are sensitive to changes in external packages. It's often not obvious whether some failure is due to our changes or due to some dependency. Daily runs without any code changed make it easier to notice and pinpoint these issues. Especially for all the sphinx-related stuff it has been pretty time consuming to fix such issues...

@FFroehlich
Copy link
Member

I see the motivation for doing this for benchmark collection models, but why do we need this for performance/documentation?

They are sensitive to changes in external packages. It's often not obvious whether some failure is due to our changes or due to some dependency. Daily runs without any code changed make it easier to notice and pinpoint these issues. Especially for all the sphinx-related stuff it has been pretty time consuming to fix such issues...

👍

@dweindl dweindl merged commit e988505 into develop Oct 26, 2021
@dweindl dweindl deleted the test_nightly_benchmark_models branch October 26, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants