Adding CITATION.cff file.

[stephanmg]

Addresses issue #1558.

[dweindl]

👍

Could you please include the paper as preferred-citation?

[codecov]

Codecov Report

Merging #1559 (fb4706a) into develop (a91833c) will increase coverage by 0.20%.
The diff coverage is 79.32%.

❗ Current head fb4706a differs from pull request most recent head 1610447. Consider uploading reports for the commit 1610447 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1559      +/-   ##
===========================================
+ Coverage    78.68%   78.89%   +0.20%     
===========================================
  Files           65       67       +2     
  Lines        10061    10585     +524     
===========================================
+ Hits          7917     8351     +434     
- Misses        2144     2234      +90     

Flag	Coverage Δ
cpp	75.41% <75.47%> (+0.18%)	⬆️
petab	67.01% <49.53%> (-2.47%)	⬇️
python	67.55% <65.96%> (-0.17%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
include/amici/abstract_model.h	0.00% <ø> (ø)
include/amici/edata.h	0.00% <ø> (ø)
include/amici/newton_solver.h	100.00% <ø> (ø)
include/amici/rdata.h	94.44% <ø> (ø)
include/amici/simulation_parameters.h	66.66% <ø> (ø)
include/amici/solver.h	100.00% <ø> (ø)
include/amici/solver_cvodes.h	100.00% <ø> (ø)
include/amici/solver_idas.h	100.00% <ø> (ø)
include/amici/vector.h	87.50% <ø> (+18.75%)	⬆️
python/amici/__main__.py	0.00% <0.00%> (ø)
... and 38 more

[stephanmg]

Could you please check if this is now okay?

[dweindl]

Suggested change

	given-names "Glenn Terje"
	given-names: "Glenn Terje"

[stephanmg]

CITATION.cff now validated and renders on branch stephanmg/cff_file of the AMICI fork.

[FFroehlich]

I am wondering whether we really want to include the zenodo information. There is a zenodo badge for that in the repository after all and the version/doi will quickly go stale.

[stephanmg]

I am wondering whether we really want to include the zenodo information. There is a zenodo badge for that in the repository after all and the version/doi will quickly go stale.

I agree, should I remove it?

[yannikschaelte]

I am wondering whether we really want to include the zenodo information. There is a zenodo badge for that in the repository after all and the version/doi will quickly go stale.

There is a "cite all" doi too, which could be used? When someone wants to cite a specific version, they would need to look the specific doi up on zenodo anyways.

[FFroehlich]

I am wondering whether we really want to include the zenodo information. There is a zenodo badge for that in the repository after all and the version/doi will quickly go stale.

There is a "cite all" doi too, which could be used? When someone wants to cite a specific version, they would need to look the specific doi up on zenodo anyways.

Thats a good idea, then we should simply drop the version information though!

[stephanmg]

Okay, will make the changes accordingly.

[stephanmg]

Okay, cite all key is now used, version information dropped. Can somebody give hint on the merge conflict in python/sdist/setup.cfg?

[dweindl]

Can somebody give hint on the merge conflict in python/sdist/setup.cfg?

You (probably unintentially) merged some additional changes here:

Merge branch 'develop' of github.com:stephanmg/AMICI into cff_file
78a3d66

[stephanmg]

Okay, should be fixed now.

[dweindl]

Looks good to me, thanks.

[FFroehlich]

👍

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information