Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace distutils imports #1557

Merged
merged 6 commits into from
Oct 10, 2021
Merged

Replace distutils imports #1557

merged 6 commits into from
Oct 10, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 8, 2021

distutils is deprecated in Python 3.10 and to be removed in Python 3.12. Where possible, use corresponding functionality from setuptools.

Closes #1553

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #1557 (89bf3b7) into develop (9d2f906) will increase coverage by 0.09%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1557      +/-   ##
===========================================
+ Coverage    78.96%   79.05%   +0.09%     
===========================================
  Files           67       67              
  Lines        10585    10662      +77     
===========================================
+ Hits          8358     8429      +71     
- Misses        2227     2233       +6     
Flag Coverage Δ
cpp 75.51% <ø> (ø)
petab 67.01% <19.04%> (ø)
python 67.55% <28.57%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/custom_commands.py 37.50% <16.66%> (ø)
python/amici/setuptools.py 57.69% <44.44%> (ø)
python/amici/ode_export.py 92.79% <0.00%> (-0.05%) ⬇️

@dweindl dweindl mentioned this pull request Oct 8, 2021
7 tasks
@dweindl dweindl marked this pull request as draft October 9, 2021 19:04
@dweindl dweindl marked this pull request as ready for review October 9, 2021 21:01
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

27.3% 27.3% Coverage
0.0% 0.0% Duplication

@dweindl dweindl merged commit 49a2898 into develop Oct 10, 2021
@dweindl dweindl deleted the maint_1553_distutils branch October 10, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants