Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SUNMatrixWrapper functions #1538

Merged
merged 8 commits into from
Jul 30, 2021
Merged

Optimize SUNMatrixWrapper functions #1538

merged 8 commits into from
Jul 30, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 30, 2021

  • Avoid array bound-checks within loops
  • Avoid repeated function calls in loops
  • Make some functions inlinable

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1538 (b0e787c) into develop (e981d74) will decrease coverage by 0.04%.
The diff coverage is 76.31%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1538      +/-   ##
===========================================
- Coverage    79.03%   78.99%   -0.05%     
===========================================
  Files           67       67              
  Lines        10567    10579      +12     
===========================================
+ Hits          8352     8357       +5     
- Misses        2215     2222       +7     
Flag Coverage Δ
cpp 75.51% <76.31%> (-0.06%) ⬇️
petab 67.24% <ø> (ø)
python 67.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sundials_matrix_wrapper.cpp 81.88% <65.07%> (-1.91%) ⬇️
include/amici/sundials_matrix_wrapper.h 88.52% <90.19%> (+8.52%) ⬆️

@dweindl dweindl requested a review from FFroehlich July 30, 2021 14:39
src/sundials_matrix_wrapper.cpp Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl merged commit 36a86f3 into develop Jul 30, 2021
@dweindl dweindl deleted the optimize_transpose branch July 30, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants