Py: Add failfast argument to simulate_petab #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1528 +/- ##
===========================================
+ Coverage 79.25% 79.28% +0.03%
===========================================
Files 67 67
Lines 10439 10439
===========================================
+ Hits 8273 8277 +4
+ Misses 2166 2162 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Kudos, SonarCloud Quality Gate passed! |
dilpath
approved these changes
Jul 9, 2021
| @@ -51,6 +51,7 @@ def simulate_petab( | |||
| scaled_parameters: Optional[bool] = False, | |||
| log_level: int = logging.WARNING, | |||
| num_threads: int = 1, | |||
| failfast: bool = True, | |||
There was a problem hiding this comment.
Suggested change
| failfast: bool = True, | |
| fail_fast: bool = True, |
| @@ -82,6 +83,9 @@ def simulate_petab( | |||
| :param num_threads: | |||
| Number of threads to use for simulating multiple conditions | |||
| (only used if compiled with OpenMP). | |||
| :param failfast: | |||
There was a problem hiding this comment.
Suggested change
| :param failfast: | |
| :param fail_fast: |
| num_threads=num_threads) | ||
| rdatas = amici.runAmiciSimulations( | ||
| amici_model, solver, edata_list=edatas, | ||
| num_threads=num_threads, failfast=failfast) |
There was a problem hiding this comment.
Suggested change
| num_threads=num_threads, failfast=failfast) | |
| num_threads=num_threads, fail_fast=fail_fast) |
|
Ah, would need to change elsewhere too, nevermind. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.