Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix substitution of expressions in drootdt_total #1512

Merged
merged 4 commits into from
May 28, 2021
Merged

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented May 28, 2021

Not sure if this is a recent error, or if SymPy never used the dictionary order, but this fixes an error for a student's model where w symbols appeared in the generated C++ for stau.

@dilpath dilpath requested a review from FFroehlich May 28, 2021 20:48
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #1512 (a19d968) into develop (39aad8d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1512      +/-   ##
===========================================
+ Coverage    79.39%   79.46%   +0.07%     
===========================================
  Files           67       67              
  Lines        10399    10399              
===========================================
+ Hits          8256     8264       +8     
+ Misses        2143     2135       -8     
Flag Coverage Δ
cpp 75.88% <ø> (+0.11%) ⬆️
petab 67.66% <0.00%> (ø)
python 68.25% <100.00%> (ø)
sbmlsuite 88.06% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/ode_export.py 93.15% <100.00%> (ø)
src/exception.cpp 82.60% <0.00%> (ø)
src/solver_cvodes.cpp 70.20% <0.00%> (ø)
src/sundials_matrix_wrapper.cpp 84.21% <0.00%> (+0.42%) ⬆️
src/amici.cpp 75.65% <0.00%> (+5.21%) ⬆️

@dilpath dilpath changed the title Reverse toposort order, manually substitute to ensure order Fix substitution of expressions in drootdt_total May 28, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dilpath dilpath merged commit 56c0fec into develop May 28, 2021
@dilpath dilpath deleted the fix_toposort branch May 28, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants