Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sllh computation from petab_objective.simulate_petab #1498

Merged
merged 12 commits into from
Apr 16, 2021
Merged

Remove sllh computation from petab_objective.simulate_petab #1498

merged 12 commits into from
Apr 16, 2021

Conversation

FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Apr 15, 2021 •
edited
Loading

removes sllh computation from petab objective.

  • didn't account for parameter transformation anyways
  • didn't account for plist
  • wasn't used (or tested) anywhere

@dweindl dweindl linked an issue Apr 15, 2021 that may be closed by this pull request
Gradient tests for benchmark collection #967
Closed
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #1498 (ec108e3) into develop (57b3cb4) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1498      +/-   ##
===========================================
- Coverage    79.50%   79.44%   -0.07%     
===========================================
  Files           66       66              
  Lines        10407    10390      -17     
===========================================
- Hits          8274     8254      -20     
- Misses        2133     2136       +3
Flag Coverage Δ
cpp 75.88% <ø> (ø)
petab 67.92% <0.00%> (+0.07%) ⬆️
python 68.50% <0.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_objective.py 95.26% <0.00%> (+4.40%) ⬆️
python/amici/sbml_import.py 95.01% <0.00%> (-1.03%) ⬇️
python/amici/ode_export.py 92.63% <0.00%> (-0.54%) ⬇️

@FFroehlich FFroehlich requested a review from dweindl April 15, 2021 20:51
@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl dweindl removed a link to an issue Apr 16, 2021
Gradient tests for benchmark collection #967
Closed
@dweindl dweindl changed the title Fix petab aggregate sllh Remove petab aggregate sllh Apr 16, 2021
@dweindl dweindl changed the title Remove petab aggregate sllh Remove sllh computation from petab_objective.simulate_petab Apr 16, 2021
@FFroehlich FFroehlich changed the title Remove sllh computation from petab_objective.simulate_petab Remove sllh computation from petab_objective.simulate_petab Apr 16, 2021
@FFroehlich FFroehlich merged commit 980ace2 into develop Apr 16, 2021
@FFroehlich FFroehlich deleted the fix_petab_aggregate_sllh branch April 16, 2021 14:31
@dilpath dilpath mentioned this pull request Sep 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FFroehlich @dweindl