Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Update OpenBLAS Windows installation instructions #1496

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Doc: Update OpenBLAS Windows installation instructions #1496

merged 2 commits into from
Apr 15, 2021

Conversation

willov
Copy link
Contributor

@willov willov commented Apr 15, 2021

The current version of compileBLAS.cmd / installOpenBLAS.ps1 does not use a "v" in the top-level OpenBLAS-0.3.12 folder.

Backward slashes got removed during installation of amici. Switching to forward slashes worked.

The current version of compileBLAS.cmd / installOpenBLAS.ps1 does not use a "v" in the top-level OpenBLAS-0.3.12 folder. 

Backward slashes got removed during installation of amici. Switching to forward slashes worked.
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #1496 (4f0bdb4) into develop (2243699) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1496      +/-   ##
===========================================
- Coverage    79.50%   79.48%   -0.02%     
===========================================
  Files           66       66              
  Lines        10407    10407              
===========================================
- Hits          8274     8272       -2     
- Misses        2133     2135       +2     
Flag Coverage Δ
cpp 75.85% <ø> (-0.03%) ⬇️
petab 67.85% <ø> (ø)
python 68.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sundials_matrix_wrapper.cpp 83.78% <0.00%> (-0.43%) ⬇️

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting that, @willov

@dweindl dweindl changed the base branch from master to develop April 15, 2021 15:28
@dweindl dweindl changed the title Update INSTALL.md Doc: Update OpenBLAS Windows installation instructions Apr 15, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl dweindl merged commit cc0b253 into AMICI-dev:develop Apr 15, 2021
dweindl added a commit that referenced this pull request Oct 10, 2021
More up-to-date installation instructions are available in readthedocs.

Applied changes from #1496
dweindl added a commit that referenced this pull request Oct 11, 2021
More up-to-date installation instructions are available in readthedocs.

Applied changes from #1496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants