Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1492 ("maybe-uninitialized") #1495

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Fix #1492 ("maybe-uninitialized") #1495

merged 2 commits into from
Apr 14, 2021

Conversation

FFroehlich
Copy link
Member

No description provided.

@FFroehlich FFroehlich requested a review from dweindl April 14, 2021 03:37
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #1495 (6a5141b) into develop (989497a) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1495      +/-   ##
===========================================
+ Coverage    79.42%   79.54%   +0.11%     
===========================================
  Files           66       66              
  Lines        10406    10407       +1     
===========================================
+ Hits          8265     8278      +13     
+ Misses        2141     2129      -12     
Flag Coverage Δ
cpp 75.94% <100.00%> (+0.17%) ⬆️
petab 67.85% <ø> (ø)
python 68.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rdata.cpp 95.06% <100.00%> (+<0.01%) ⬆️
src/solver_cvodes.cpp 70.41% <0.00%> (+0.20%) ⬆️
src/sundials_matrix_wrapper.cpp 84.42% <0.00%> (+0.63%) ⬆️
src/amici.cpp 75.65% <0.00%> (+5.21%) ⬆️
src/exception.cpp 91.30% <0.00%> (+8.69%) ⬆️

@dweindl dweindl changed the title fix #1492 Fix #1492 ("maybe-uninitialized") Apr 14, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit 2243699 into develop Apr 14, 2021
@FFroehlich FFroehlich deleted the fix_1492 branch April 14, 2021 14:36
@dweindl dweindl linked an issue Apr 15, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maybe-uninitialized warning
2 participants