Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timepoint specific observables #1469

Merged
merged 49 commits into from
Mar 23, 2021
Merged

Fix timepoint specific observables #1469

merged 49 commits into from
Mar 23, 2021

Conversation

FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Mar 18, 2021 •
edited
Loading

fixes #1214

@codecov
Copy link

codecov bot commented Mar 18, 2021 •
edited
Loading

Codecov Report

Merging #1469 (cc17e66) into develop (4b2d950) will decrease coverage by 0.01%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1469      +/-   ##
===========================================
- Coverage    79.42%   79.41%   -0.02%     
===========================================
  Files           66       66              
  Lines        10353    10361       +8     
===========================================
+ Hits          8223     8228       +5     
- Misses        2130     2133       +3
Flag Coverage Δ
cpp 75.75% <ø> (ø)
petab 67.76% <81.25%> (-0.02%) ⬇️
python 68.15% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_import.py 71.05% <75.00%> (-0.70%) ⬇️
python/amici/petab_import_pysb.py 93.33% <100.00%> (+0.19%) ⬆️

@FFroehlich FFroehlich marked this pull request as ready for review March 18, 2021 21:08
dweindl
dweindl approved these changes Mar 18, 2021
View reviewed changes
python/amici/petab_import.py Outdated Show resolved Hide resolved
python/amici/petab_import.py Outdated Show resolved Hide resolved
python/amici/petab_import.py Outdated Show resolved Hide resolved
python/amici/petab_import.py
Comment on lines +783 to +786
parser.add_argument('--flatten', dest='flatten', default=False,
action='store_true',
help='Flatten measurement specific overrides of '
'observable and noise parameters')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

python/amici/petab_import.py Outdated Show resolved Hide resolved
python/amici/petab_import.py Outdated Show resolved Hide resolved
yannikschaelte
yannikschaelte approved these changes Mar 18, 2021
View reviewed changes
python/amici/petab_import.py Outdated Show resolved Hide resolved
python/amici/petab_import.py Outdated Show resolved Hide resolved
python/amici/petab_import.py Outdated Show resolved Hide resolved
python/amici/petab_import.py Outdated Show resolved Hide resolved
python/amici/petab_import.py Outdated Show resolved Hide resolved
dweindl
dweindl reviewed Mar 22, 2021
View reviewed changes
python/sdist/setup.cfg Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit 34cfdad into develop Mar 23, 2021
@FFroehlich FFroehlich deleted the fix_timepoint_specific_observables branch March 23, 2021 02:21
@dweindl dweindl mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

@yannikschaelte yannikschaelte yannikschaelte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FFroehlich @dweindl @yannikschaelte