Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Crauste ref val, fixes #1458 #1459

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Fix Crauste ref val, fixes #1458 #1459

merged 2 commits into from
Mar 14, 2021

Conversation

yannikschaelte
Copy link
Member

No description provided.

@yannikschaelte yannikschaelte self-assigned this Mar 14, 2021
@codecov
Copy link

codecov bot commented Mar 14, 2021 •
edited
Loading

Codecov Report

Merging #1459 (fbd5479) into develop (d83f85c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1459      +/-   ##
===========================================
+ Coverage    79.13%   79.15%   +0.01%     
===========================================
  Files           66       66              
  Lines        10191    10191              
===========================================
+ Hits          8065     8067       +2     
+ Misses        2126     2124       -2
Flag Coverage Δ
cpp 75.73% <ø> (+0.02%) ⬆️
petab 69.72% <ø> (ø)
python 67.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sundials_matrix_wrapper.cpp 84.21% <0.00%> (+0.42%) ⬆️

FFroehlich
FFroehlich approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@FFroehlich FFroehlich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you confirm there was a sign error in the "analytical" solution?

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yannikschaelte yannikschaelte merged commit 11afe62 into develop Mar 14, 2021
@yannikschaelte yannikschaelte deleted the fix_crauste branch March 14, 2021 16:44
@dweindl dweindl linked an issue Mar 15, 2021 that may be closed by this pull request
LLH reference value for Crauste_CellSystems2017 #1458
Closed
@dweindl dweindl mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees

@yannikschaelte yannikschaelte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LLH reference value for Crauste_CellSystems2017
2 participants
@yannikschaelte @FFroehlich