Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for compilation without sensitivities #1454

Merged
merged 21 commits into from
Mar 10, 2021
Merged

Implement support for compilation without sensitivities #1454

merged 21 commits into from
Mar 10, 2021

Conversation

FFroehlich
Copy link
Member

Unfortunately doesn't seem to yield much of an improvement in import time.

@FFroehlich FFroehlich requested a review from dweindl March 9, 2021 15:50
@codecov
Copy link

codecov bot commented Mar 9, 2021 •
edited
Loading

Codecov Report

Merging #1454 (99d43bd) into develop (d933926) will increase coverage by 0.09%.
The diff coverage is 90.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1454      +/-   ##
===========================================
+ Coverage    79.11%   79.20%   +0.09%     
===========================================
  Files           66       66              
  Lines        10147    10192      +45     
===========================================
+ Hits          8028     8073      +45     
  Misses        2119     2119
Flag Coverage Δ
cpp 75.81% <0.00%> (+0.03%) ⬆️
petab 69.72% <94.91%> (+0.24%) ⬆️
python 67.88% <100.00%> (+0.36%) ⬆️
sbmlsuite 87.89% <98.30%> (-2.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/pysb_import.py 93.88% <ø> (ø)
python/amici/sbml_import.py 95.94% <ø> (ø)
src/amici.cpp 75.65% <0.00%> (-4.17%) ⬇️
python/amici/ode_export.py 92.92% <100.00%> (+0.20%) ⬆️
src/solver_cvodes.cpp 70.41% <0.00%> (+0.20%) ⬆️
src/sundials_matrix_wrapper.cpp 84.63% <0.00%> (+0.42%) ⬆️
src/abstract_model.cpp 5.15% <0.00%> (+2.06%) ⬆️
src/exception.cpp 91.30% <0.00%> (+8.69%) ⬆️

dweindl
dweindl approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

python/amici/sbml_import.py Outdated Show resolved Hide resolved
@dweindl
Copy link
Member

dweindl commented Mar 9, 2021 •
edited
Loading

Unfortunately doesn't seem to yield much of an improvement in import time.

Hm, for which model? For large ones, I'd expect a significant improvement.

(Let's see... https://github.com/AMICI-dev/AMICI/actions/workflows/test_performance.yml)

@dweindl dweindl linked an issue Mar 9, 2021 that may be closed by this pull request
Model import: Optional generation of sensitivity equations #1359
Closed
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

71.8% 71.8% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit 35b490e into develop Mar 10, 2021
@FFroehlich FFroehlich deleted the no_sensi_import branch March 10, 2021 23:59
@dweindl dweindl mentioned this pull request Mar 16, 2021
Merged
@dweindl dweindl mentioned this pull request Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model import: Optional generation of sensitivity equations
2 participants
@FFroehlich @dweindl