Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated petab.Problem.from_files in amici.petab.cli.import_petab._main #2460

Closed
dweindl opened this issue Jun 16, 2024 · 0 comments · Fixed by #2464
Closed

Replace deprecated petab.Problem.from_files in amici.petab.cli.import_petab._main #2460

dweindl opened this issue Jun 16, 2024 · 0 comments · Fixed by #2464
Assignees
@dweindl
Labels
PEtab PEtab-import related

Comments

@dweindl
Copy link
Member

dweindl commented Jun 16, 2024 •
edited
Loading

Replace deprecated petab.Problem.from_files in amici.petab.cli.import_petab._main.

Also deprecate passing individual PEtab tables to amici_import_petab on the command line (who is doing that anyways?), but while it's still in place, check that the parameter table is present.
@dweindl dweindl added the PEtab PEtab-import related label Jun 16, 2024
@dweindl dweindl self-assigned this Jun 25, 2024
dweindl added a commit to dweindl/AMICI that referenced this issue Jun 25, 2024
@dweindl
Deprecated passing individual tables to amici_import_petab
f9f6c61 
and replace deprecated `petab.Problem.from_files` in `amici.petab.cli.import_petab._main`.

Fixes AMICI-dev#2460
@dweindl dweindl mentioned this issue Jun 25, 2024
Merged
@dweindl dweindl linked a pull request Jun 26, 2024 that will close this issue
Deprecate passing individual tables to amici_import_petab #2464
Merged
@dweindl dweindl closed this as completed in 538fd59 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
PEtab PEtab-import related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate passing individual tables to amici_import_petab dweindl/AMICI
1 participant
@dweindl