Avoid segfault in CVODES CVAdataStore (#1351)

Does not fix the root cause of occassional segfaults, but turns them into exceptions / integration failues.
AMICI-dev · Dec 2, 2020 · a13db57 · a13db57
1 parent 156d37a
commit a13db57
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/ThirdParty/sundials/src/cvodes/cvodea.c b/ThirdParty/sundials/src/cvodes/cvodea.c
@@ -2026,6 +2026,9 @@ static int CVAdataStore(CVodeMem cv_mem, CkpntMem ck_mem)
   /* Run CVode to set following structures in dt_mem[i] */
   i = 1;
   do {
+    // Modified for AMICI
+    // (dt_mem has dimension ca_mem->ca_nsteps)
+    if (i > ca_mem->ca_nsteps) return(CV_FWD_FAIL);
 
     flag = CVode(cv_mem, ck_mem->ck_t1, ca_mem->ca_ytmp, &t, CV_ONE_STEP);
     if (flag < 0) return(CV_FWD_FAIL);