Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for MCDM driver #52

Merged
merged 12 commits into from
Aug 7, 2024
Merged

Conversation

mariodruiz
Copy link
Collaborator

Describe the problem solved by the commit

Add support for MCDM driver

How is the problem solved?

Rework npu top to show dummy app names

Are there any risks associated to the change?

More stress test with the new driver should be done

Is there a documentation impact?

No

Checklist

  • Existing and new test pass
  • I read and I accept the CONTRIBUTING.md guidelines

@STFleming
Copy link
Collaborator

Hi @mariodruiz, I have not had a chance to take a look yet, but I noticed that in xrt-smi from the MCDM driver we are seeing a HW Context ID. Do you know if this is something that is reported/accessible via XRT? It might be possible to reconstruct the name of the running apps using this?

image

Copy link
Collaborator

@skalade skalade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Mario, the changes to the tests dir don't seem to be relevant to this PR. Could u remove them and maybe open a new one for the tests improvements? Makes easier to track down changes it history

@mariodruiz
Copy link
Collaborator Author

@skalade the tests/test_endtoend.py fails with the new driver. I assumed due to the kernel accessing more data that is supposed to.

Do you want me to move tests/test_endtoend.py to a different PR?
I agree with the comments for other tests

@mariodruiz
Copy link
Collaborator Author

@STFleming

Do you know if this is something that is reported/accessible via XRT? It might be possible to reconstruct the name of the running apps using this?

I am not sure. xrt-smi is the same tool in Linux, so this PR technically works in Linux, albeit the apps show up as app<id>

@skalade
Copy link
Collaborator

skalade commented Aug 6, 2024

@skalade the tests/test_endtoend.py fails with the new driver. I assumed due to the kernel accessing more data that is supposed to.

Do you want me to move tests/test_endtoend.py to a different PR? I agree with the comments for other tests

Ah ok sorry I didn't realize it was tied to the changes

@STFleming STFleming merged commit fb9762c into AMDResearch:main Aug 7, 2024
2 checks passed
@mariodruiz mariodruiz deleted the raisw1.2 branch September 14, 2024 11:21
@mariodruiz mariodruiz mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants