extra symbols to wsl path resolution #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skalade
added a commit
to skalade/Riallto
that referenced
this pull request
Jun 27, 2024
* Fix link to Ryzen AI webpage (AMDResearch#31) * extra symbols to wsl path resolution (AMDResearch#10) * Latest version of numpy causing issues, constraining it to v1.* (AMDResearch#35) * Latest version of numpy causing issues, constraining it to v1.* * readability fix * Enable Kernel fusion (AMDResearch#34) * Include library of kernels in the compilation * Fix typos * Include kernels header file * Prepare kernels for superkernel * Include test name * Initial superkernel test * Simplyfy test * Add second superkernel * Rename test to better reflect the nature of PR * Rename test to better reflect the nature of PR * Align code * Fix call * More fixes * Remove fake kernels * Kernel fusion working!!!! * Fix duplicate variable name * Add another test * Remove unnecesary flag * Remove * revert to original * Revert to original * Revert to original * Revert to original * Include kernels * Copy kernel * Import shutil * Allow to load the same Riallto app up to 4 times (AMDResearch#36) * Allow multiple instances of the same app to be run * Try to fix test * Add more tests * Flake8 * More appropiate test name * Make sure AppRunner has device, device is not found is previous call had an space issue * Made code more pythonic * Handle AppRunner object even if it fails * Flake8 * Report app start column (AMDResearch#37) * Allow multiple instances of the same app to be run * Try to fix test * Add more tests * Flake8 * More appropiate test name * Make sure AppRunner has device, device is not found is previous call had an space issue * Made code more pythonic * Handle AppRunner object even if it fails * Flake8 * Try to add start column * Add starting column * Flake8 * Update check * Fix where assert is done * Fix issue with counting * Check that xbutil count is working * Do not run xbutil test for Linux * Add missing os import * Skip test in Linux --------- Co-authored-by: Sarunas Kalade <[email protected]> Co-authored-by: Shane Fleming <[email protected]>
STFleming
added a commit
that referenced
this pull request
Jul 2, 2024
* Splitting the install steps and adding a Linux install step (#10) * Splitting the install steps and adding a linux install step * Added the FAQ changes * Moving the install steps to markdown instead of rst for Linux and applying Mario's feedback. * added starting from as suggested by Mario * Added separate steps in obtaining the MAC for Windows and Ubuntu * Adding new launch jupyter steps to the documentation * clarification on MAC address * Updating the driver info to reflect the v1.1 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem solved by the commit
This fixes bug found by @cathalmccabe. If install is run from e.g. "C:/users/john/downloads/my folder (1)/" it will currently fail because we don't escape the special ')' characters when converting to wsl strings.
Btw it looks like '(' is being replaced by same '(', but this actually does what we want because the first argument of -replace is a regular expression, the second one is the string that will be inserted, so functionally '(' -> '\('.
How is the problem solved?
Add a one-liner to the copy_files_to_wsl.ps1 script.
Checklist
Signed-off-by: skalade [email protected]