-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[createRoadblock] fixed nil return to array to fix an error #475
Conversation
shukari
commented
Nov 27, 2017
•
edited
Loading
edited
- fixed description
- optimised one statment (no time for more)
- it was possible to return NIL, but ALiVE_fnc_INS_helpers need everytime an array, fixed
- fixed description - optimised one statment (no time for more) - it was possible to return NIL, but ALiVE_fnc_INS_helpers need everytime an array, fixed
Looks good, does it work for you locally? |
cant test atm |
its fine, no hurry - just give us a shot once you ran it up initially |
}; | ||
} foreach _roads; | ||
_roads = _roads - [objNull]; | ||
_roads = _roads select {_x distance _pos < (_radius - 10) || {!isOnRoad _x} || {(str _x) find "invisible" != -1}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i'm reading this correct, it will return the exact opposite of what the previous code returned, since the _roads set [_foreachIndex,objNull];
and _roads = _roads - [objNull];
?!
This would explain why i didn't get any roadblocks spawned, only a bunch of ALiVE Roadblock <Obj-Null> is not on a road [0,0,0]! Not created...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are totally right...
I'll do a testbuild and give it a whirl when i get home |
Thank you @Whigital , i cant test all my stuff because i can script on this notebook but i can only start arma 3 on my PC and that one is far away for quite some time. |
Seems to be working as expected now: roadblocks spawn where they should. |
like @Whigital said... all is working... why no merge? |
Thanks Whigital for verifying - must have missed/forgotten the last comments, sorry - we will merge it then! |
All me baby |
sorry for the delay @shukari - and thanks for all the effort! |
* Update fnc_createRoadblock.sqf - fixed description - optimised one statment (no time for more) - it was possible to return NIL, but ALiVE_fnc_INS_helpers need everytime an array, fixed * [FIX] wrong select * i've been bamboozled