Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[createRoadblock] fixed nil return to array to fix an error #475

Merged
merged 3 commits into from
Jan 9, 2018
Merged

[createRoadblock] fixed nil return to array to fix an error #475

merged 3 commits into from
Jan 9, 2018

Conversation

shukari
Copy link
Contributor

@shukari shukari commented Nov 27, 2017

  • fixed description
  • optimised one statment (no time for more)
  • it was possible to return NIL, but ALiVE_fnc_INS_helpers need everytime an array, fixed

shukari and others added 2 commits November 16, 2017 09:22
- fixed description
- optimised one statment (no time for more)
- it was possible to return NIL, but ALiVE_fnc_INS_helpers need everytime an array, fixed
@friznit friznit added the Ready label Nov 27, 2017
@highhead
Copy link
Contributor

Looks good, does it work for you locally?

@shukari
Copy link
Contributor Author

shukari commented Nov 27, 2017

cant test atm

@highhead
Copy link
Contributor

its fine, no hurry - just give us a shot once you ran it up initially

};
} foreach _roads;
_roads = _roads - [objNull];
_roads = _roads select {_x distance _pos < (_radius - 10) || {!isOnRoad _x} || {(str _x) find "invisible" != -1}};
Copy link
Contributor

@Whigital Whigital Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i'm reading this correct, it will return the exact opposite of what the previous code returned, since the _roads set [_foreachIndex,objNull]; and _roads = _roads - [objNull]; ?!

This would explain why i didn't get any roadblocks spawned, only a bunch of ALiVE Roadblock <Obj-Null> is not on a road [0,0,0]! Not created...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totally right...

@Whigital
Copy link
Contributor

Whigital commented Dec 4, 2017

I'll do a testbuild and give it a whirl when i get home

@shukari
Copy link
Contributor Author

shukari commented Dec 4, 2017

Thank you @Whigital , i cant test all my stuff because i can script on this notebook but i can only start arma 3 on my PC and that one is far away for quite some time.

@Whigital
Copy link
Contributor

Whigital commented Dec 4, 2017

Seems to be working as expected now: roadblocks spawn where they should.

@shukari
Copy link
Contributor Author

shukari commented Jan 9, 2018

like @Whigital said... all is working... why no merge?

@highhead
Copy link
Contributor

highhead commented Jan 9, 2018

Thanks Whigital for verifying - must have missed/forgotten the last comments, sorry - we will merge it then!

@DavisBrown723 DavisBrown723 merged commit a410c06 into ALiVEOS:master Jan 9, 2018
@DavisBrown723
Copy link
Contributor

All me baby

@highhead
Copy link
Contributor

sorry for the delay @shukari - and thanks for all the effort!

DarrellJMartin pushed a commit that referenced this pull request Feb 6, 2018
* Update fnc_createRoadblock.sqf

- fixed description
- optimised one statment (no time for more)
- it was possible to return NIL, but ALiVE_fnc_INS_helpers need everytime an array, fixed

* [FIX] wrong select

* i've been bamboozled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants