Give the Slurm collector safer defaults

[rkleinem]

As discussed. Not much to change.

If the user doesn't specify a config entry, it's good to use defaults.
If they specify something we don't know it's likely an error and we should stop.

Also, I would argue that a sensible choice for the earliest datetime is just now.
One day can be 30,000 records already...

[stefan-k]

Thank you for the fix!

Also, I would argue that a sensible choice for the earliest datetime is just now. One day can be 30,000 records already...

My suggestion was based on the fact that sacct itself has something similar in place when no time is specified. However, I must admit that I don't recall the specific time span. I'm fine with now, as it is the least dangerous default.

Could you fix the failing Clippy lint, please? The other CI failures are not related to your contribution.

[rkleinem]

I removed the unused import. Is that what you meant?
Since I don't have experience with github workflows I'm not sure but it seems like clippy will always throw an error if started from a fork (actions-rs/clippy-check#2).
Or is there a way to fix that?

[stefan-k]

I removed the unused import. Is that what you meant?

Yes, thanks!

Since I don't have experience with github workflows I'm not sure but it seems like clippy will always throw an error if started from a fork (actions-rs/clippy-check#2). Or is there a way to fix that?

Ah sorry, yes, this is not something you should (or even can) fix. I've learned to ignore this error/warning and didn't think of mentioning it ;) Sorry!

[stefan-k]

Ah, now I finally understand. I thought you had a typo in the datetime string, but you had a typo in the key. Now I understand why the parsing of the datetime string didn't fail :)

LGTM.

[rkleinem]

Ah, now I finally understand. I thought you had a typo in the datetime string, but you had a typo in the key. Now I understand why the parsing of the datetime string didn't fail :)

Yes, that was it. Maybe I was a little unclear.