feat: Add PHP template #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sironheart
force-pushed
the
feat/add-php
branch
from
4b8a094 to
841d270
Compare
hbjydev
requested changes
Apr 17, 2024
Sironheart
force-pushed
the
feat/add-php
branch
from
841d270 to
fb148da
Compare
hbjydev
approved these changes
Apr 17, 2024
hbjydev
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Okay, so. When trying to build this, it seems this doesn't output anything resembling a binary or script in the /bin path in the derivation output.
/tmp/tmp.mUjAv72oFJ via 🐘
❯ nix run .
error: unable to execute '/nix/store/pn5ag15jq0kkrw6iwd36hh74wwak9q5j-example-0.1.0/bin/example': No such file or directoryIf this won't create any form of entrypoint executable, that's fine, but we'll drop the package entries for it and make it a dev shell-only one. Unless you can think of a better implementation here?
Happy for you to implement this as a binary, but I'll not merge this in its current state as it 'builds' but has nothing to run.
We can chat more about it in Discord if I've been unclear at all here.
Sironheart
force-pushed
the
feat/add-php
branch
from
1709db8 to
8f0af67
Compare
Sironheart
force-pushed
the
feat/add-php
branch
from
8f0af67 to
6ee1130
Compare
hbjydev
reviewed
Apr 18, 2024
hbjydev
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.