Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model & endpoints for user feedback #164

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add model & endpoints for user feedback #164

merged 1 commit into from
Oct 4, 2023

Conversation

scy
Copy link
Collaborator

@scy scy commented Oct 4, 2023

Implements the feedback form parts of #37.

@t-muehlberger, the endpoints can be used to check whether a token is still valid to be used, and also to provide the Destination data required to display the MEP. I’ve also included a language field that you can use to initialize the frontend to; it will be set to the language in use when initiating the call. This is useful if the User opens the feedback form from a different browser (e.g. on their phone).

@t-muehlberger, would you like me to add a mockup version of this to #141? I’d prefer to avoid that, because it’s additional effort to copy-paste the code around and create a mockup for it, but if it makes your life significantly easier I’ll do it nevertheless ;)

@jbethune, if you want to, you can review this. Maybe … idk, react with 👀 on this description when you intend to do one, so that I don’t merge it before you’re done?

@scy scy added type:enhancement New feature or request area:backend Related to the server component labels Oct 4, 2023
@scy scy added this to the 2.0: instant call support milestone Oct 4, 2023
@scy scy self-assigned this Oct 4, 2023
@scy scy mentioned this pull request Oct 4, 2023
@t-muehlberger
Copy link
Collaborator

@scy I don't really need a mock version of the endpoint, I will checkout this brach. What is the best way how I can get a feedback-token for testing?

@scy
Copy link
Collaborator Author

scy commented Oct 4, 2023

What is the best way how I can get a feedback-token for testing?

Right now, probably by inserting a row into the database manually. For example:

sqlite3 dearmep.sqlite "insert into user_feedback (token, issued_at, expires_at, destination_id, calling_code, language) values ('FTHNZBGH', '2023-10-04 09:05', '2023-10-11 09:05', '96750', 49, 'de');"

Sorry, didn’t have time to write a CLI for that just now.

Make sure to run dearmep db init first to create the necessary table. I’m also working on a prepared base database dump for development with all the new tables that we have, but that too won’t include a token.

@t-muehlberger
Copy link
Collaborator

@scy perfect thank you, the SQL Insert will work just fine for me.
Yes I have already initiated my local version of the DB to be up to date with the latest schema changes.

@scy scy merged commit 21c6097 into main Oct 4, 2023
@scy scy deleted the user-feedback branch October 4, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:backend Related to the server component type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants