-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Python 3.8 & 3.12 in CI builds #163
Conversation
I’ve subscribed to that issue and will update this PR once there’s been a release. |
Okay, now the issue is that I guess we’ll wait for MagicStack/httptools#94 to be resolved. We’re pulling |
Okay, now we’re blocked by x = f"{foo["bar"]}" However, Python < 3.12 doesn’t. Now, flake8-quotes complains that we’re using single quotes inside of our f-strings, but we have to to maintain backwards compatibility. I won’t disable that check (Q000) because it applies both to quotes outside and inside of f-strings, so we’ll lose most of our quote checking. On the other hand, flake8-quotes seems not exactly well maintained. There’s no maintainer activity in the respective issue. Maybe we’ll just have to move to |
Oldest and most recent supported versions.
In preparation for Ruff not supporting setup.cfg.
It's only reporting errors for now, I'll make it mandatory after having fixed or ignore a lot of errors :)
For 3.12 compatibility.
Also output in GitHub's format, this may give us inline annotations or something.
Should fix `type 'typing.TypeVar' is not an acceptable base type`.
This _might_ fix the `TypeError: issubclass() arg 1 must be a class` error that we're now getting on 3.8, which is, according to The Internet™, related to upgrading typing-extensions.
Since flake8-quotes still isn't ready for 3.12 due to lacking a maintainer, I've removed flake8 completely and instead went for Ruff, which is better in the long run anyway. Ruff is obviously throwing lots of errors for our existing codebase now, which is why I've set it to only report errors, but not cause the build (or |
Oldest and most recent supported versions.