phplot.php: type casts for PHP 8.2 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As announced in issue comment, I´ve just cast the arguments of the calls used for my use cases to int. Of course, a more profound approach would be to type the respective function parameters or class properties to int or, if anyway needed, nullable int (?int), but that might break compatibility with PHP 7.x.
|
👍🏽 |
|
@AJRepo any chance you accept this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As announced in issue comment, I´ve just cast the arguments of the calls used for my use cases to int, which fixes PHP 8.2 type mismatch notifications.
Of course, a more profound approach would be to type the respective function parameters or class properties to int or, if anyway needed, nullable int (?int), but that might break backward compatibility with PHP 7.x.