Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

구글 애널리틱스 RouterChangeTracker 연결 #93

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

MyungJiwoo
Copy link
Collaborator

@MyungJiwoo MyungJiwoo commented Oct 5, 2024

🪄 목적

관련 이슈 : #91



💻 상세 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요.

  • 구글 애널리틱스 RouterChangeTracker 연결
  • RouterChangeTracker을 연결하려다보니 BrowserRouter 중첩 문제가 발생해서 App.tsx에 있던 BrowserRouter를 index.tsx로 옮겼습니다.


📸 스크린샷



👼🏻 리뷰 요구사항 (선택)

리뷰어가 특별히 봐줬으면 하는 부분이 있다면 작성해주세요.

  • 추후 로그인 유무에 따른 라우터 문제가 발생하면 수정해야 할 것 같습니다.

@MyungJiwoo MyungJiwoo self-assigned this Oct 5, 2024
@MyungJiwoo MyungJiwoo merged commit 63e1114 into main Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant