-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements: Move nose and sphinx to dev requirements. See #230 #231
Conversation
flake8 | ||
flake8-import-order | ||
sphinx>=1.4 | ||
sphinx_rtd_theme>=0.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this require user to install the dev version of pyradiomics before documentation can be built? (or have users install sphinx
and sphinx-rtd-theme
manually?)
What do you mean by dev version ? To summarize, as it was before building the doc can be achieved doing:
The advantage of this commit is that it avoids installing sphinx related packages while simply doing I would also suggest to remove this line: https://github.com/Radiomics/pyradiomics/blob/d00212cd407d96604d5d9f1581661547efd3be3a/MANIFEST.in#L15 |
Building the docs does require pyradiomics to be installed, as it uses the This is not needed for the online documentation on readthedocs, but it is reflected in the downloadable pdf or custom build documentation (this was set at 0.0.1). I changed this in #216 to use the actual version of pyradiomics.
I agree |
@jcfr, can you update the manifest and merge? |
@jcfr, what is the status on this PR? |
99bbb0b
to
6d77fd0
Compare
Rebased onto master to resolve conflict (due to the removal of the |
6d77fd0
to
17000a6
Compare
Needed to run tests.
Update documentation to reflect changes made in #231
No description provided.