Skip to content

Commit

Permalink
[wip] Bump pylint version to make tests pass
Browse files Browse the repository at this point in the history
  • Loading branch information
tmadlener committed Oct 12, 2023
1 parent 75a6d43 commit 8ef2475
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
# fails
git config --global --add safe.directory $(pwd)
pip install pre-commit
pip install pylint==2.12.2
pip install pylint==2.17.7
pip install flake8
echo "::endgroup::"
echo "::group::Run CMake"
Expand Down
2 changes: 1 addition & 1 deletion python/podio/test_ReaderRoot.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import unittest

from test_Reader import ReaderTestCaseMixin, LegacyReaderTestCaseMixin # pylint: disable=import-error
from test_utils import LEGACY_DATA_AVAILABLE
from podio.test_utils import LEGACY_DATA_AVAILABLE

from podio.root_io import Reader, LegacyReader

Expand Down
3 changes: 2 additions & 1 deletion python/podio/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@
ROOT.gSystem.Load("libTestDataModelDict.so") # noqa: E402
from ROOT import ExampleHitCollection, ExampleClusterCollection # noqa: E402 # pylint: disable=wrong-import-position

from podio import Frame # pylint: disable=wrong-import-position
from .frame import Frame # pylint: disable=wrong-import-position


SKIP_SIO_TESTS = os.environ.get("SKIP_SIO_TESTS", "1") == "1"
LEGACY_DATA_AVAILABLE = os.environ.get("PODIO_TEST_INPUT_DATA_DIR", None) is not None


def create_hit_collection():
"""Create a simple hit collection with two hits for testing"""
hits = ExampleHitCollection()
Expand Down

0 comments on commit 8ef2475

Please sign in to comment.