Move unique_ptr instead of releasing and acquiring it

AIDASoft · May 12, 2024 · 3d19f2e · 3d19f2e
1 parent 72cf930
commit 3d19f2e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/include/podio/Reader.h b/include/podio/Reader.h
@@ -22,7 +22,7 @@ class Reader {
 
   template <typename T>
   struct ReaderModel final : public ReaderConcept {
-    ReaderModel(T* reader) : m_reader(reader) {
+    ReaderModel(std::unique_ptr<T> reader) : m_reader(std::move(reader)) {
     }
     ReaderModel(const ReaderModel&) = delete;
     ReaderModel& operator=(const ReaderModel&) = delete;

diff --git a/src/Reader.cc b/src/Reader.cc
@@ -15,7 +15,7 @@
 namespace podio {
 
 template <typename T>
-Reader::Reader(std::unique_ptr<T> reader) : m_self(std::make_unique<ReaderModel<T>>(reader.release())) {
+Reader::Reader(std::unique_ptr<T> reader) : m_self(std::make_unique<ReaderModel<T>>(std::move(reader))) {
 }
 
 Reader makeReader(const std::string& filename) {