Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
resolves Create check if geometry and field are not empty #361
The Detector object has a state
Detector::state()
with three values:It starts with
NOT_READY
, moves toLOADING
once the geometry is opened and goes toREADY
once the geometry is closed. As suggested in the developers meeting: the initial field object is invalid and gets created only once the geometry is opened. As a corollary, the field may not be accessed before. Geometry parsers must take this behavior into account!Address some compiler warnings.
Implement a module to invoke python as a DD4hep plugin:
invoked e.g. by:
geoPluginRun -plugin DD4hep_Python -dd4hep -prompt
Implementation wise the plugin is a simple CLI wrapper for TPython.
ENDRELEASENOTES