Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lifted-pddl package #131

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Added lifted-pddl package #131

merged 3 commits into from
Aug 29, 2023

Conversation

TheAeryan
Copy link
Contributor

This pull request adds a new package, lifted-pddl, to planutils. This was requested in the following issue.

To create this planutils package, I have followed the implementation (manifest.json, etc.) of pyperplan and tarski. If you feel something is missing/incorrect, please feel free to change my implementation.

Also, while testing lifted-pddl inside planutils I have observed that it does not work for parameters containing blank spaces. I tried using lifted-pddl outside planutils and it did work, so I believe this issue has to do with how planutils parses its command-line arguments. I opened an issue about this problem. As soon as it is solved, everything should work fine.

@TheAeryan TheAeryan closed this Aug 26, 2023
@TheAeryan TheAeryan reopened this Aug 26, 2023
@TheAeryan
Copy link
Contributor Author

I have solved the issue and now everything works fine, so pull request can be accepted (I closed the pull request by mistake).

@haz
Copy link
Contributor

haz commented Aug 29, 2023

Thanks for including it and working through the bug!

@haz haz merged commit cc4bd5c into AI-Planning:main Aug 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants