-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added advanced usage example for a notebook interacting with a Cloud … #178
Conversation
xpk-notebooks.md
Outdated
```shell | ||
xpk cluster create --cluster ${CLUSTER} \ | ||
--project=${PROJECTID} --default-pool-cpu-machine-type=n2-standard-8 \ | ||
--num-slices=2 --tpu-type=v5litepod-256 --zone=${ZONE} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently lws only support single slice, let us keep the num_slices=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That explains it. Will do.
xpk-notebooks.md
Outdated
containers: | ||
- name: jupyter-notebook-server | ||
image: jupyter/base-notebook:latest | ||
# env: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let us remove those comments
xpk-notebooks.md
Outdated
- -c | ||
- | | ||
sleep 20 | ||
cat /app/ipp/security/ipcontroller-client.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also those two debug lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, added a few comments to clean up debug code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so that after @yejingxin approves, this can be merged.
…TPU cluster
Fixes / Features
Testing / Documentation
Testing details.