Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added advanced usage example for a notebook interacting with a Cloud … #178

Merged
merged 4 commits into from
Aug 24, 2024

Conversation

nhira
Copy link
Collaborator

@nhira nhira commented Aug 21, 2024

…TPU cluster

Fixes / Features

  • changed README.md to add reference to advanced usage (xpk-notebooks.md)

Testing / Documentation

Testing details.

  • [ y/n ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

@nhira nhira requested a review from Obliviour as a code owner August 21, 2024 23:43
xpk-notebooks.md Outdated
```shell
xpk cluster create --cluster ${CLUSTER} \
--project=${PROJECTID} --default-pool-cpu-machine-type=n2-standard-8 \
--num-slices=2 --tpu-type=v5litepod-256 --zone=${ZONE} \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently lws only support single slice, let us keep the num_slices=1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That explains it. Will do.

xpk-notebooks.md Outdated
containers:
- name: jupyter-notebook-server
image: jupyter/base-notebook:latest
# env:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us remove those comments

xpk-notebooks.md Outdated
- -c
- |
sleep 20
cat /app/ipp/security/ipcontroller-client.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also those two debug lines

Copy link

@yejingxin yejingxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, added a few comments to clean up debug code.

Copy link
Collaborator

@Obliviour Obliviour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so that after @yejingxin approves, this can be merged.

@nhira nhira merged commit 886b6bc into main Aug 24, 2024
6 checks passed
@nhira nhira deleted the nb-journey branch August 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants