This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fix reachability tests #3694
Merged
Fix reachability tests #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.46% (diff: 100%)@@ master #3694 diff @@
==========================================
Files 45 45
Lines 6235 6229 -6
Methods 1101 1104 +3
Messages 0 0
Branches 415 416 +1
==========================================
- Hits 5455 5448 -7
- Misses 777 778 +1
Partials 3 3
|
0xced
force-pushed
the
fix-reachability-tests
branch
from
fe5233f to
d2becfd
Compare
|
Now that we have passing tests, I'm not sure we need this. Thoughts? |
0xced
force-pushed
the
fix-reachability-tests
branch
from
d2becfd to
7879b51
Compare
This pattern does not make sense at all because the assert can never fail.
if (condition) {
XCTAssert(condition, @"comment");
}
Do not use XCTAssertEqual(reachable, ...) because it might transition to AFNetworkReachabilityStatusNotReachable before becoming reachable.
The status passed in callbacks (both block and notification) is captured before the callbacks are dispatched on the main thread. It is thus possible that the reachabilityManager status change in the meantime. Users MUST use the status parameter for the block callback or the `AFNetworkingReachabilityNotificationStatusItem` user info key for the notification.
0xced
force-pushed
the
fix-reachability-tests
branch
from
7879b51 to
fb5022c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully these changes will fix the domain reachability tests.