Sylvia whittle/596 zscale grains #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
+ Coverage 80.82% 80.94% +0.12%
==========================================
Files 19 19
Lines 2832 2845 +13
==========================================
+ Hits 2289 2303 +14
+ Misses 543 542 -1
☔ View full report in Codecov by Sentry. |
|
Ran this code, it works and produces the results I wanted from issue #596 |
ns-rse
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Looks good and setting to [None, None] is the way it should have been in the first place. Thanks @SylviaWhittle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #596
This PR makes it so that the
z-rangeset in the config file is applied to all non-binary images, not just thecoreimage set. This has been done by editingupdate_plotting_configto no longer remove thezrangeitem from theplot_dictdictionaries and instead, sets the item to[None, None]for binary images, and sets it to the user defined range for non-binary images.I have updated the test
test_update_plotting_configintest_utils.pyaccordingly to check that binary and non-binary images behave as expected.The new outputs with a
z-rangeof[-3, 4]applied:Binary images are still black and white, but the non-binary images are now appropriately scaled.