Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more info to cores-1 bug report label #1050

Merged

Conversation

MaxGamill-Sheffield
Copy link
Collaborator

TopoStats Pull Requests

Although #887 was suitably implemented by an earlier PR using broad try-except statements while also showing the error and filename, it was pointed out that the bug report template needs adjusting. It now states
"Find the offending file in the output. If processing halts, re-run analysis with topostats --core 1 process."
and Closes #887

Copy link
Collaborator

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order of arguments needs tweaking in light of some refactoring I undertook as part of #517.

Suggestion in line.

Have we addressed the #887 though in so much as we report the images that are causing errors/failures and continue processing? If so then we could do away with the advice to run with a single core and ask users to report which images are problematic.

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
@MaxGamill-Sheffield
Copy link
Collaborator Author

Order of arguments needs tweaking in light of some refactoring I undertook as part of #517.

Suggestion in line.

Have we addressed the #887 though in so much as we report the images that are causing errors/failures and continue processing? If so then we could do away with the advice to run with a single core and ask users to report which images are problematic.

Yep I've just added that as you were typing this and noticed the command line ordering too. Have adjusted these to say the following which should hopefully resolve our worries:
"Find the offending file in the output. If processing halts, re-run analysis with topostats --core 1 process."

@MaxGamill-Sheffield MaxGamill-Sheffield added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 9683480 Dec 12, 2024
11 checks passed
@MaxGamill-Sheffield MaxGamill-Sheffield deleted the maxgamill-sheffield/adjust-bug-report-template branch December 12, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.3.0
Projects
None yet
2 participants