chore: Remove unused method, test and package dependencies #1049
+1
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns-rse
force-pushed
the
ns-rse/1036-remove-unused-loadscan-method
branch
from
f80e625 to
e5d3b51
Compare
Closes #1036 With the delegation of much I/O (Input/Output) functionality to @SylviaWhittle `AFMReader` (see #1031) we have removed most of the methods to the `io.LoadScan()` class. One that slipped through was `_spm_pixel_to_nm_scaling()` and this commit removes it along with its associated test. Further the delegation of reading AFM files using `AFMReader` means `TopoStats` no longer has explicit dependencies on the `igor2`, `pySPM` or `tifffile` packages and so these have been removed from the `dependencies` section of `pyproject.toml`. These are dependencies of `AFMReader` and will still be installed in virtual environments. Moved `pytest-testmon` from `tests` to `dev` under optional dependencies as its not used when running the test suite, only when making commits locally.
ns-rse
force-pushed
the
ns-rse/1036-remove-unused-loadscan-method
branch
from
e5d3b51 to
b5673d0
Compare
MaxGamill-Sheffield
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1036
With the delegation of much I/O (Input/Output) functionality to @SylviaWhittle
AFMReader(see #1031) we have removed most of the methods to theio.LoadScan()class. One that slipped through was_spm_pixel_to_nm_scaling()and this commit removes it along with its associated test.Further the delegation of reading AFM files using
AFMReadermeansTopoStatsno longer has explicit dependencies on theigor2,pySPMortifffilepackages and so these have been removed from thedependenciessection ofpyproject.toml. These are dependencies ofAFMReaderand will still be installed in virtual environments.Moved
pytest-testmonfromteststodevunder optional dependencies as its not used when running the test suite, only when making commits locally.Before submitting a Pull Request please check the following.