Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit and regression tests #5

Closed
bobturneruk opened this issue Sep 14, 2020 · 1 comment
Closed

Add unit and regression tests #5

bobturneruk opened this issue Sep 14, 2020 · 1 comment

Comments

@bobturneruk
Copy link
Member

Identify functions, classes, etc. and develop tests. A unit test is akin to checking that the brakes work on a car, as opposed to a regression test which would be driving the car to Bologna. pytest is a widely used test framework.

@bobturneruk
Copy link
Member Author

This was, in retrospect, poorly worded! Tests should be added with new code as it is merged into https://github.com/AFM-SPM/TopoStats/tree/dev

ns-rse added a commit that referenced this issue Dec 16, 2024
In addressing #986 I tested in a fresh virtual environment. This pulled in
[matplotlib-3.10.0](https://github.com/matplotlib/matplotlib/releases/tag/v3.10.0) which was released 2024-12-14 (two
days ago!). Our dependency on [topoly](topoly.cent.uw.edu.pl/documentation.html) doesn't work with this new version
because of the removal of `inset_location.InsetPosition` in favour of `inset_axes`.

This has been reported to the Topoly developers, see [ImportError: cannot import name 'InsetPosition' from
'mpl_toolkits.axes_grid1.inset_locator' · Issue #5 ·
ilbsm/topoly_tutorial](ilbsm/topoly_tutorial#5) and hopefully won't take long to resolve. For
now though we pin our dependency `matplotlib~=3.9.4` and all tests pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant