Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libafl): update Z3 dependency #1372

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

saruman9
Copy link
Contributor

@saruman9 saruman9 commented Jul 19, 2023

See Z3Prover/z3#5586. libafl with cmin feature cannot be built for Android.

@domenukk
Copy link
Member

I'm not sure if we can refer to git repositories when we try to publish LibAFL to crates.io (cc @andreafioraldi )
In any case, I think the z3 folks should release a new version on crates? Can you open an issue there?

@domenukk
Copy link
Member

That being said, I thought we had a cmin without Z3 as well? CC @addisoncrump

@saruman9
Copy link
Contributor Author

I'm not sure if we can refer to git repositories when we try to publish LibAFL to crates.io (cc @andreafioraldi ) In any case, I think the z3 folks should release a new version on crates? Can you open an issue there?

I think you are absolutely right. But so far I don't see any progress in the process of publishing a new version. prove-rs/z3.rs#237

@addisoncrump
Copy link
Collaborator

Yeah I need to replace cmin. Once #981 lands, I'll port over the merge strategy, but it won't be compat with e.g. PowerScheduler like the current cmin.

@waywardmonkeys
Copy link

I've published z3 0.12 (and z3-sys 0.8)!

@domenukk
Copy link
Member

@saruman9 do you want to update your PR to use 0.12?

See Z3Prover/z3#5586. libafl with `cmin` feature cannot be built for Android.
@saruman9 saruman9 force-pushed the fix_z3_android_build branch from 6cc7b9a to 35fd4ff Compare July 24, 2023 13:05
@domenukk
Copy link
Member

Thanks! :)

@domenukk domenukk merged commit 993eb62 into AFLplusplus:main Jul 24, 2023
@saruman9 saruman9 changed the title fix(libafl): use Z3 repository with fixed commit fix(libafl): update Z3 dependency Jul 24, 2023
@saruman9 saruman9 deleted the fix_z3_android_build branch July 24, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants