init #1
init #1
Conversation
| # - name: Run unit tests | ||
| # working-directory: ./core | ||
| # run: yarn test |
There was a problem hiding this comment.
Should this be uncommented or is this because there currently are not tests??
There was a problem hiding this comment.
Because there aren't currently tests, next dev day perhaps
core/README.md
Outdated
| **Middleware** | ||
|
|
||
| ```ts | ||
| export const i18NextPDFGenerator = pdfMiddlewareBuilder( |
There was a problem hiding this comment.
I would maybe call i18NextPDFGenerator i18NextPDFMiddleware to make it clear that this returns an express compatible middleware.
| "homepage": "https://github.com/AES-Outreach/express-react-pdf#readme", | ||
| "dependencies": { | ||
| "@react-pdf/renderer": "^3.0.0", | ||
| "express": "^4.18.1", |
There was a problem hiding this comment.
Regarding express potentially not needing to be a dependency, we could take a look at other packages that supply express compatible middleware and see if they have express as a dependency in any way. I wouldn't use a single example to make the decision but if we can find a few packages that might give us an idea.
There was a problem hiding this comment.
So looking at this: microsoft/types-publisher#81
I think they are supposed to be in dependencies?
There was a problem hiding this comment.
But honestly i'm still not totally sure. Most of the express middleware packages I found are not typescript and don't seem to have it in dependencies
could you please clarify? |
No description provided.