Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make allowances for session timeout resetting UNION default behaviour #36

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

ADBond
Copy link
Owner

@ADBond ADBond commented Oct 7, 2024

Closes #33.

Introduces function ClickhouseAPI.set_union_default_mode(), which in addition to be called on object initialisation can be called independently. This makes it easier for users running interactively, or otherwise in some script where there may be a long period of non-interaction with the db, to re-set the setting necessary for clustering (and possibly other functions).

For now this seems preferable to automatically setting this e.g. every time we execute SQL. But if this proves to be irritating then we can always trigger this function when certain conditions are met.

Additionally to avoid this potentially coming up in tests we change from having DatabaseAPI fixtures to making them factory fixtures, so that the apis only get instantiated within tests rather than for the lifetime of the fixture.

@ADBond ADBond added bug Something isn't working testing labels Oct 7, 2024
@ADBond ADBond merged commit a2226e0 into main Oct 7, 2024
15 checks passed
@ADBond ADBond deleted the bug/session-timeout branch October 7, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clustering fails if we wait too long
1 participant