Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer post-trick animations #25

Merged
merged 12 commits into from
Jun 14, 2023
Merged

Nicer post-trick animations #25

merged 12 commits into from
Jun 14, 2023

Conversation

ADBond
Copy link
Owner

@ADBond ADBond commented May 31, 2023

Improving animations when tricks are won and cards go to their destinations:

  • rotate cards so they are 'right-way-up' to the person they are heading to
  • cards to the trick-pile get 'flipped' to face-down
  • stagger animation of each card of the trick to help display what's occuring

@ADBond
Copy link
Owner Author

ADBond commented Jun 6, 2023

This has highlighted some brittleness in how I've been dealing with sequential animations, so will need to rejig how things are handled. Most likely will use existing methods to manage a queue instead of playing animations, and then a final notification that just executes the queue

@ADBond
Copy link
Owner Author

ADBond commented Jun 14, 2023

Keeping the splitting up of calypso complete logic / fresh cards thing as I think it is a bit clearer what's going on, and gives me the option of going back if needed

@ADBond ADBond merged commit 8b5c52a into dev Jun 14, 2023
@ADBond ADBond deleted the rotatey-cards branch June 14, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant