Allow plain outgoing_node_id in blinded payment_relay
#2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we're the introduction node of a trampoline blinded path, we previously only allowed our custom `wallet_node_id` format when a `short_channel_id` was not included. But we actually can allow plain `node_id`s as well, as we only need to know the public key. We've rejected some payments in the past months because they included an `outgoing_node_id` that didn't use the wallet format: by removing that limitation we ensure that those payments will be correctly relayed in the future.
thomash-acinq
previously approved these changes
Nov 22, 2024
thomash-acinq
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're the introduction node of a trampoline blinded path, we previously only allowed our custom
wallet_node_idformat when ashort_channel_idwas not included. But we actually can allow plainnode_ids as well, as we only need to know the public key.We've rejected some payments in the past months because they included an
outgoing_node_idthat didn't use the wallet format: by removing that limitation we ensure that those payments will be correctly relayed in the future.