-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensible Liquidity Ads #2848
Merged
Merged
Extensible Liquidity Ads #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
liquidity-ads-official
branch
from
May 14, 2024 09:03
f1c6334
to
cb2183e
Compare
t-bast
force-pushed
the
liquidity-ads-official
branch
from
June 4, 2024 14:28
cb2183e
to
1f9048e
Compare
t-bast
force-pushed
the
liquidity-ads-official
branch
3 times, most recently
from
June 14, 2024 11:24
6fc8334
to
e23a6f5
Compare
t-bast
force-pushed
the
liquidity-ads-official
branch
5 times, most recently
from
June 25, 2024 06:59
e83eaea
to
ff2f88b
Compare
t-bast
force-pushed
the
liquidity-ads-official
branch
from
June 27, 2024 15:09
ff2f88b
to
3474de7
Compare
t-bast
force-pushed
the
liquidity-ads-official
branch
from
July 5, 2024 08:47
3474de7
to
c3f5e61
Compare
t-bast
force-pushed
the
liquidity-ads-official
branch
from
July 17, 2024 12:35
c3f5e61
to
347adf4
Compare
This was referenced Jul 19, 2024
Closed
t-bast
force-pushed
the
liquidity-ads-official
branch
from
July 22, 2024 09:04
347adf4
to
738604c
Compare
t-bast
force-pushed
the
liquidity-ads-official
branch
from
July 31, 2024 15:09
738604c
to
4e1db8d
Compare
t-bast
force-pushed
the
liquidity-ads-official
branch
2 times, most recently
from
August 28, 2024 07:55
b52d01f
to
a31bca3
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2848 +/- ##
==========================================
+ Coverage 85.98% 86.06% +0.08%
==========================================
Files 219 220 +1
Lines 18538 19015 +477
Branches 786 818 +32
==========================================
+ Hits 15939 16365 +426
- Misses 2599 2650 +51
|
t-bast
force-pushed
the
liquidity-ads-official
branch
from
September 5, 2024 12:57
629ce61
to
5ab74ba
Compare
pm47
requested changes
Sep 6, 2024
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala
Outdated
Show resolved
Hide resolved
pm47
reviewed
Sep 6, 2024
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LiquidityAds.scala
Show resolved
Hide resolved
t-bast
force-pushed
the
liquidity-ads-official
branch
4 times, most recently
from
September 13, 2024 14:27
c77ff37
to
f63f175
Compare
The initiator of `open_channel2`, `tx_init_rbf` and `splice_init` can request funding from the remote node. The non-initiator node will: - let the open-channel-interceptor plugin decide whether to provide liquidity for new channels or not, and how much - always honor liquidity requests on existing channels (RBF and splice) when funding rates have been configured Liquidity ads are included in the `node_announcement` message, which lets buyers compare sellers and connect to sellers that provide rates they are comfortable with. They are also included in the `init` message which allows providing different rates to specific peers. This implements lightning/bolts#1153. We currently use the temporary tlv tag 1339 while we're waiting for feedback on the spec proposal.
Creating a new channel has an additional cost compared to adding liquidity to an existing channel: the channel will be closed in the future, which will require paying on-chain fees. Node operators can include a `channel-creation-fee-satoshis` in their liquidity ads to cover some of that future cost.
Whenever liquidity is purchased, we store it in the `AuditDb`. This lets node operators gather useful statistics on their peers, and which ones are actively using the liquidity that is purchased. We store minimal information about the liquidity ads itself to be more easily compatible with potential changes in the spec.
t-bast
force-pushed
the
liquidity-ads-official
branch
from
September 24, 2024 01:42
f63f175
to
c6a1199
Compare
pm47
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initiator of
open_channel2
,tx_init_rbf
andsplice_init
can request funding from the remote node. The non-initiator node will:Liquidity ads are included in the
node_announcement
message, which lets buyers compare sellers and connect to sellers that provide rates they are comfortable with. They are also included in theinit
message which allows providing different rates to specific peers.This implements lightning/bolts#1153. We currently use the temporary tlv tag 1339 while we're waiting for
feedback on the spec proposal.